Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix updating library freeze #898

Merged
merged 4 commits into from
Jan 15, 2024
Merged

fix updating library freeze #898

merged 4 commits into from
Jan 15, 2024

Conversation

nguyd1
Copy link
Contributor

@nguyd1 nguyd1 commented Jan 14, 2024 •
edited
Loading

bug: when the last novel in the library gives an error (ex. cloudflare) then the app will be unable to start another library update until u force stop the app

  1. moved resolve and schedule notif after the for loop
  2. removed the if isrunning inside the try since the for loop already checks for it

@rajarsheechatterjee rajarsheechatterjee merged commit 64ef4ba into LNReader:main Jan 15, 2024
1 check passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2024
@nguyd1 nguyd1 deleted the bugfix/fix-updating-library branch October 1, 2024 00:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rajarsheechatterjee rajarsheechatterjee rajarsheechatterjee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nguyd1 @rajarsheechatterjee