Modified selection function to be updatable #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature requests and enhancements
I suggest we implement the completeness and purity kernels in firecrown/models/cluster/kernel.py with free parameters that can be sampled by cosmosis.
Problem description
First of all, there is an error in the current kernel implementation. Current implementation is using logm/logmc whereas it should be m/mc, as per Aguena, 2016. However I also propose that we implement these functions as we did in mass_proxy.py, where the parameters will be set by cosmosis instead of hard coded. Even if we do not sample over these parameters, they will be different for different input data (i.e. galaxy cluster catalogs obtained from different cluster finders). Also, I think it would be helpful if we can sample over the parameters. We can find a fit from cosmological simulations and then I suggest a gaussian prior centered on these fit parameters to give some freedom for the fit.
Proposed solution
Change Completeness and Purity classes in firecrown/models/cluster/kernel.py to be updatable objects with 4 parameters each.