Project/afw table/ishasan #116
Conversation
|
made changes suggested in stack club. Biggest changes:
|
|
Hey @ih64 - apologies for the looong delay on reviewing this. I thought I remembered you saying you were thinking of extending this notebook a bit, but since I don't see any commits beyond the stack club group-review I guess that extension is on hold (or not planned) and the ball is still squarely in my court for reviewing/approving this. If I can get a good enough connection at Newark airport in tomorrow's club session I will do it then. |
There was a problem hiding this comment.
This is great, @ih64 - really nice work! I fixed a bunch of typos while working through your notebook, and will submit an easy PR against this branch with those. I then have just one final request - that we show how to make a table with ra and dec in degrees, not radians. I'll pre-approve though, so that you can merge whenever you've added that last feature. Thanks very much, this is going to be most useful!
Basics/afw_table_guided_tour.ipynb
Outdated
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "Notice to set the ra and dec, we needed to create afwGeom.Angle objects. These are in units of radians by default. Additionally, we set the parent to zero. This means this record refers to the object before any deblending occoured. Lets look at our table now to see how it stands" |
There was a problem hiding this comment.
Your example ra and dec look like they are in degrees, not radians - but I think it will be common for people to have coordinates in degrees. Perhaps this example should include showing what to do if this is indeed your situation. I guess the right thing to do is define the unit to be degrees when you instantiate the afwgeom.Angles? And then my last tiny suggestion is that your example dec should lie between 0 ad -70 deg :-)
There was a problem hiding this comment.
Thanks @drphilmarshall! I now explicitly set the unit using keyword arguments when making afwGeom.Angles. Ready to merge (^^)/
…ble/drphilmarshall Fixed text bugs in afwTables tour
this PR is for issue #51 , a guided tour to AFW tables in the basics section. Ready for comments and review :)