Feature Request

[xmenxwk]

Upon further usage, I came to realize BaseLicense.Features is <string, bool> which is good for true/false features, but sometimes there are other types. I would suggest using something more flexible like byte[], you can store any data in it.

Also about Features.Key, its string, since both license generator app and license validator app will share a common id, I would suggest using an integer as key, it will reduce file size of license if there are many features. Having string key seems to give no benefit.

Something like this

        Dictionary<int, byte[]> Features = new();
        public static byte[]? GetFeature(int featureId)
        {
            if (Current is null)
                return null;//or throw exception

            if (Current.Features.TryGetValue(featureId, out byte[]? features))
                return features;

            return null;
        }

        public static bool IsFeatureEnabled(int featureId)
        {
            byte[]? data = GetFeature(featureId);

            if (data is not null && data.Length == 1)
                return Convert.ToBoolean(data[0]);

            return false;//or throw exception
        }

[xmenxwk]

....

[LSXPrime]

It looks like I was away for long. Sorry, I was busy working on a new library for Cross-Platform Sound Playback, Recording and Advanced Processing library for .NET (although my current use case is just simple playback & recording) since the current solutions are very limited and require the user to install additional platform-specified applications and packages. Your suggestion looks good. If possible, I would consider a more generic approach to avoid a breaking change, given the significant changes made in recent releases, and potentially move the features to a more dedicated class. I will start working on this.

…

On Mon, 23 Dec 2024 at 08:43, xmenxwk ***@***.***> wrote: .... — Reply to this email directly, view it on GitHub <#11 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AXX7JISDJA2R755WHKHNB2L2G6WIVAVCNFSM6AAAAABSQT5Y2CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNJZGAYTIMBQHE> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[xmenxwk]

Great. Looking for update. I'm more interested in byte[] as I m using such stuff everywhere.