Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I feel like these suggestions are a bit to comprehensive to put in github line-by-line-comments so I made a PR to your topic branch, @LSchwerdt.
I suggest these substantial changes:
pageLocation
array and move the final partial page directly into position, removing it frompageLocation
as well, shortening the array by a total of 4 and helping simplify code.copy_pages!
to the caller which allows that function to be substantially simplerA
orB
is close to empty theoretically resulting in minor (negligible) performance improvement and also simplifying that code and setting up for "calculate location of the 3 free pages" to be much simplercopy_page!(v, source, offset, offset2, pagesize)
and replace its usages withcopyto!
which is equivalent forVectors
but may have more efficient implementations for otherAbstractVectors
And these more superficial changes:
next_page_A
andnext_page_B
that are only called once_