-
-
Notifications
You must be signed in to change notification settings - Fork 647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate to JSpecify #1019
Conversation
@@ -36,9 +35,7 @@ final class SharedLibraryLoader { | |||
|
|||
private static final Lock EXTRACT_PATH_LOCK = new ReentrantLock(); | |||
|
|||
@GuardedBy("EXTRACT_PATH_LOCK") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only use of JSR305 annotations that can't be replaced with JSpecify. We could keep JSR305 just for that but I figured it's not worth it.
0ff0bd2
to
4fae14d
Compare
Great job @TheMrMilchmann, thanks! |
Is it valid syntax to have a type, the annotation, and then .Buffer?
|
@SWinxy This is not just valid, but the only correct syntax for the Some examples from JSpecify's docs (which apply to all
|
Wild! Thanks for the info. |
See #1008 for a detailed description.
Key changes:
javax.annotation.Nullable
have been replaced withorg.jspecify.annotations.Nullable
@Nullable public static Something.Buffer ...
becomespublic static Something.@Nullable Buffer ...
@Nullable
marker now directly precedes the type before the@NativeType
annotation where applicable.org.lwjgl.system.NonnullDefault
has been removed and replaced withorg.jspecify.annotations.NullMarked
.This is a draft PR for the following reasons: