Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crypt32 bindings #851

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Crypt32 bindings #851

merged 1 commit into from
Mar 17, 2023

Conversation

TheMrMilchmann
Copy link
Contributor

Bindings for dpapi.h and crypt32.dll providing support for:

  • CryptProtectData and CryptUnprotectData, and
  • CryptProtectMemory and CryptUnprotectMemory.

This is not fully finished yet and I'll add some questions inline.

TheMrMilchmann
TheMrMilchmann commented Jan 21, 2023
View reviewed changes
Copy link
Contributor Author

@TheMrMilchmann TheMrMilchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of comments inline.

modules/lwjgl/core/src/templates/kotlin/core/windows/templates/Crypt32.kt Outdated Show resolved Hide resolved
modules/lwjgl/core/src/templates/kotlin/core/windows/templates/Crypt32.kt Outdated Show resolved Hide resolved
modules/lwjgl/core/src/templates/kotlin/core/windows/WindowsTypes.kt Outdated Show resolved Hide resolved
modules/lwjgl/core/src/generated/java/org/lwjgl/system/windows/Crypt32.java Show resolved Hide resolved
@TheMrMilchmann
Copy link
Contributor Author

(Pinging @Spasi to have a look at this because I'm not sure if GitHub notifies people about draft PRs. No hurry though. 😅)

@Spasi Spasi force-pushed the tmm/feat-crypt32 branch from ea7d769 to 507b86b Compare March 4, 2023 19:18
@Spasi
Copy link
Member

Spasi commented Mar 4, 2023

Hey @TheMrMilchmann,

I've added a commit that addresses the above questions. Will split/squash/cleanup the commits as necessary when it's time to merge this.

@TheMrMilchmann
Copy link
Contributor Author

Thanks, I just looked at your changes and I believe you have already taken care of all remaining issues. In my opinion, this is good to go. However, I'm not sure where to mention this in the changelog. Could you also take care of this? Otherwise, let me know if anything else is missing.

@TheMrMilchmann TheMrMilchmann marked this pull request as ready for review March 15, 2023 20:22
@Spasi Spasi force-pushed the tmm/feat-crypt32 branch from 507b86b to 1a35ade Compare March 17, 2023 15:49
@Spasi Spasi merged commit bdf0bd6 into LWJGL:master Mar 17, 2023
@Spasi
Copy link
Member

Spasi commented Mar 17, 2023

Thanks @TheMrMilchmann!

Did one more change before the merge, added IgnoreMissing.. to CryptProtectMemory and CryptUnprotectMemory because technically we support Windows XP and these two are available on Vista+.

@TheMrMilchmann TheMrMilchmann deleted the tmm/feat-crypt32 branch March 17, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Spasi Spasi Spasi left review comments

Assignees
No one assigned
Labels
Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheMrMilchmann @Spasi