Learn tabs initial selection state #614
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Tracking issue
There are a couple of scenarios where the learn tab selected state was not being rendered (magenta border):
cds-app.view#learn/learn/MAb
, again the tab was loaded correctly but the selection state was blank.The issue that was causing this, is on learn view initialization the selected dimension happens before the learn header store gets loaded with dimensions, so the selection state fails to fire. My solution was to wait until the store loaded to make the initial selection. I briefly looked to see if the order of selection and store loading could easily be altered but that proved to be much more complex.