Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Learn tabs initial selection state #614

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Learn tabs initial selection state #614

merged 1 commit into from
Nov 28, 2023

Conversation

labkey-klum
Copy link
Contributor

Rationale

Tracking issue

There are a couple of scenarios where the learn tab selected state was not being rendered (magenta border):

  • On initial app load when the user navigated from the home page to the learn pages. In this case the default tab is : study and while the tab was loaded, the selection state was blank.
  • If the user refreshed to a URL with a learn tab specified : cds-app.view#learn/learn/MAb, again the tab was loaded correctly but the selection state was blank.

The issue that was causing this, is on learn view initialization the selected dimension happens before the learn header store gets loaded with dimensions, so the selection state fails to fire. My solution was to wait until the store loaded to make the initial selection. I briefly looked to see if the order of selection and store loading could easily be altered but that proved to be much more complex.

@labkey-klum labkey-klum merged commit 29c8bb0 into develop Nov 28, 2023
2 checks passed
@labkey-klum labkey-klum deleted the fb_issue_49121 branch November 28, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants