Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket 49336: New Groups in Learn - fixes for navigation to the group summary page, and Groups not displaying in Learn and the Study page. #631

Merged

Conversation

labkey-bpatel
Copy link
Contributor

Rationale

Client filed issues as mentioned in Ticket 49336:

  • Groups displaying on Home page but not in Learn
  • Groups not displaying on Study page
  • Clicking on a Group from the Home page takes user to a different Group details page than expected.

Changes

  • Fix for groups not displaying on Learn pages.
  • Query update (studyCuratedGrpWithLabel.sql) to display Curated groups on Study pages, instead of having to update studyCuratedGroup table each time a new group is created, which is going to have different group id on staging and production and client would have to update tables on both staging and prod and run an ETL for the data to get populated - this query update eliminates all these steps.
  • Get the label from the clicked item and find the corresponding record based on the label instead of using Ext's auto mechanism of using store index.

labkey-adam and others added 5 commits January 5, 2024 13:32
…e Filters (#621)

* Modify 'Active Filters' section with buttons reorganized, labeled differently, and styled.
* Display Group Save panel in the Active Filters area upon clicking 'Save as a group' button.
* Group save buttons
* Implement Group Edit workflow
* Handle button and view stages during Save and Edit workflow
* Tie in already saved filters to the new workflow (i.e. display Edit button upon filter display, etc.)
* Handle Edit > Update
* Handle race condition when a user is on Group details page, and we edit or create a new group from that point on (wip).
* Hide edit button when there is an error
* Use saveParticipantGroup.api instead of updateParticipantGroup.api for edit/updates
* Fix Home page groups' View all link
* Styling updates and cleanup
* Add MAb to Learn Groups and update selectRowItem if MAb.
* Update MAb group save
* Add id for identifying components for debugging.
* Fix for Group selection - having a custom 'id' and doLayout() (which updates the layout upon item select) doesn't belong together, Ext needs to generate its own ids to be able to do the layout upon different Group selections.
* Clear filter upon group delete, test updates.
* Test updates/fixes with comments
* Client requested updates - Make error msg cds user friendly, add red border to the errored input box. Don't display group details page upon save, customize Group label in the Filter pane to have 'cds' red color and with a hyperlink to the groupsummary/details page.
…y Curated groups on Study pages. Added log messages for troubleshooting.
…- get the label from the clicked item and find the corresponding record based on the label.
@labkey-bpatel labkey-bpatel merged commit 7b814be into release24.1-SNAPSHOT Jan 23, 2024
1 of 2 checks passed
@labkey-bpatel labkey-bpatel deleted the 24.1_fb_group_display_related_fixes branch January 23, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants