Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the reports test #681

Merged
merged 4 commits into from
Jan 28, 2025
Merged

Updating the reports test #681

merged 4 commits into from
Jan 28, 2025

Conversation

labkey-sweta
Copy link
Contributor

@labkey-sweta labkey-sweta commented Jan 27, 2025

Rationale

Waiting longer for "View data" to load.
image

Link to teamcity test failure https://teamcity.labkey.org/buildConfiguration/LabKey_Trunk_LabkeyPremiumTrunk_GitModules_CdsPostgres95/3352480

The fix is for CDSRReportsTest.validateViewReportBasic and CDSRReportsTest.validateViewReportComplex

Related Pull Requests

Changes

Copy link
Member

@labkey-tchad labkey-tchad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth consulting Karl as to whether it is acceptable for the schema browser to take >10 seconds to load. It takes around 5 seconds for me locally but only if I clear caches before hitting the schema browser.

@labkey-sweta labkey-sweta merged commit 76ba3fd into develop Jan 28, 2025
3 of 4 checks passed
@labkey-sweta labkey-sweta deleted the fb_reportsTestUpdate branch January 28, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants