Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 47303: Fix bad URL in route change after clicking link in success message #1103

Merged
merged 4 commits into from
Feb 14, 2023
Merged

Issue 47303: Fix bad URL in route change after clicking link in success message #1103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
420361b
Issue 47303: fix bad URL redirection from SamplesCreatedSuccessMessage
labkey-susanh Feb 14, 2023
c671e9b
v2.288.2-badAddToStorageUrl.0
labkey-susanh Feb 14, 2023
acbdf75
Release date
labkey-susanh Feb 14, 2023
b99a531
v2.288.2
labkey-susanh Feb 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@labkey/components",
"version": "2.288.1",
"version": "2.288.2",
"description": "Components, models, actions, and utility functions for LabKey applications and pages",
"sideEffects": false,
"files": [
Expand Down
4 changes: 4 additions & 0 deletions packages/components/releaseNotes/components.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
# @labkey/components
Components, models, actions, and utility functions for LabKey applications and pages.

### version 2.288.2
*Released*: 14 February 2023
- Issue 47303: fix bad URL redirection from SamplesCreatedSuccessMessage

### version 2.288.1
*Released*: 6 February 2023
- Issue 46618: Retain result row ordering in `formatSavedResults` and `formatResults` when processing results of `QuerySelect` queries.
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/entities/SamplesCreatedSuccessMessage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ const SamplesCreatedSuccessMessageImpl: FC<SamplesCreatedSuccessMessageProps & W
sampleListingGridId,
actions
);
router.push(url.toHref());
router.push(url.toString());
} catch (e) {
setError(resolveErrorMessage(e));
}
Expand Down