FileTree and WebDav updates to support module editor scenario #259
Conversation
- prop to remove checkbox selection option from node display - support font awesome icon display for file based on WebDav iconFontCls data - call the onFileSelect callback function on node select for non-checkbox case - make the arrow toggle smaller
- add contentType and options properties to model - add param to getWebDavFiles for the non-@files case
| @@ -246,11 +263,11 @@ export class FileTree extends PureComponent<FileTreeProps, FileTreeState> { | |||
| }; | |||
|
|
|||
| // Callback to parent with actual path of selected file | |||
| onFileSelect = (id: string, checked: boolean, isDirectory: boolean): void => { | |||
| onFileSelect = (id: string, checked: boolean, isDirectory: boolean, node: any): void => { | |||
There was a problem hiding this comment.
I didn't notice this when I did the initial implementation, but looks like someone has already done a little work defining the types here in this issue. If you are up for providing some types. (Although looks like it's missing node.selected).
There was a problem hiding this comment.
I'm not going to take that on as part of this PR, but I'll add a TODO comment to the component.
I did add a knob to the existing storybook story for FileTree so that you can toggle between the allowMultiSelect true / false. I can look into adding a story / knob for useFileIconCls as well. |
# Conflicts: # packages/components/package.json # packages/components/releaseNotes/labkey/components.md
cnathe
added
TeamCity test review complete
and removed
needs TeamCity test review
labels
Rationale
The moduleEditor module will soon be making use of the FileTree component and WebDav model/actions to load the module resources in a tree view for browsing and editing resource files from the LabKey UI. The FileTree usage has a few different requirements which warrant some changes/updates to the component (see changes below).
Related Pull Requests
Changes
FileTree component
WebDav model updates for module editor browser scenario