Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fixes related to MS2 GWT deletion work #6329

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

labkey-jeckels
Copy link
Contributor

Rationale

Recent work to remove the MS2 GWT search UI broke a couple of tests. This fixes them.

Related Pull Requests

Changes

  • Don't default the dirData
  • Delete more unused code

@@ -896,7 +896,7 @@ public PathAnalysisProperties getFileAnalysisProperties(Container c, String task
if (pr == null || !pr.isValid())
throw new NotFoundException();

Path dirData = pr.getRootNioPath();
Path dirData = null;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the thing that fixes the test and makes the archived protocol not show in the drop down

@labkey-jeckels labkey-jeckels merged commit 148bab4 into develop Feb 17, 2025
8 checks passed
@labkey-jeckels labkey-jeckels deleted the fb_ms2GwtDeletionFixes branch February 17, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants