Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PlainText.INI Cluster and Array unit tests fail to deserialize floats after enforcing Dot decimal point #9

Closed
francois-normandin opened this issue Jan 15, 2022 · 2 comments
Closed

PlainText.INI Cluster and Array unit tests fail to deserialize floats after enforcing Dot decimal point #9

francois-normandin opened this issue Jan 15, 2022 · 2 comments

Comments

@francois-normandin
Copy link
Member

related to #7 , the Plaintext.INI serializer should be reviewed for consistency in handling arrays and clusters of complex type.
@francois-normandin
Copy link
Member Author

Array of floats deserialize as integers on non-US systems. Fix this in variant to attribute and attribute to variant.

@francois-normandin francois-normandin changed the title PlainText.INI Cluster and Array unit tests review after enforcing Dot decimal point PlainText.INI Cluster and Array unit tests fail to deserialize floats after enforcing Dot decimal point Jan 15, 2022
francois-normandin added a commit that referenced this issue Jan 15, 2022
@francois-normandin
[Fix #9] PlainText Cluster and Arrays deserialize decimal numbers cor…
8b38f85 
…rectly with enforcement of non-system decimal notation on non-US systems
francois-normandin added a commit that referenced this issue Jan 17, 2022
@francois-normandin
[Feature #7] Plaintext Serializer now always uses dot notation for ma…
9db2bbd 
…rshalling floating points

[Feature #8] Decimal numbers now always serialize with at least one number after the dot. Ex "1" ==> "1.0"
[Fix #9] Fixed the serializer to pass all unit tests with cluster of array and array of mismatched types.
@francois-normandin
Copy link
Member Author

implemented in 1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@francois-normandin