Cluster array bug #6
Conversation
-Cluster array with array in it (fail) -Cluster with array in it (pass) -Cluster array with simple types (pass) -Cluster with cluster array (fail) Initial fail appears to be in Serializer.PlainText\PlainTextToVariant.vi
…mment inside cluster and array case. -New bug where numeric values affected by above bug lose their values -Added tests to check that numerics preserve their values
Tests that failed: -Cluster with array - numeric array -Cluster with cluster array - nested numeric -Array of Clusters - numeric array Likely source of bug: When unmarshaling, Serializer.PlainText.lvclass:PlainTextToVairant.vi cannot preserve numeric type. Conversion of kvp variants to strict variants in OpenVariant.lvlib:Variant_KVP to Strict Variant.vi requires matching numeric types under the true -> default -> array (x40) case.
|
Thanks for the submission @IlyaVino |
|
@IlyaVino I will close your pull request as the complete fix required intervention in the DataManipulation library, so your fix would have stayed incomplete. Thanks for going through the process, I really appreciate. In the meantime, if you'd like to give it a spin before it is available on vipm.io, you can go to the release sections of both repos and download the VIP files from there. |
This is an incomplete fix for #5 so that you can have access to what I've done so far.
This is my first time contributing, so please let me know if this is not the best way to share work/if there are any best practices I've missed.