Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enviroment -> environment #219

Merged
merged 2 commits into from
Jul 26, 2023
Merged

fix: enviroment -> environment #219

merged 2 commits into from
Jul 26, 2023

Conversation

CanadaHonk
Copy link
Contributor

Technically API breaking since key changes but fixes misreading from config READY response and in a few other files.

Copy link
Owner

@Lachee Lachee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like to prevent this being a breaking change, we should just deprecate the old Enviroment and make it point to Environment.

Additionally, is there a reason for this configuration to have public setters? Does Netwonsoft.JSON require those? I cannot remember.

DiscordRPC/Configuration.cs Show resolved Hide resolved
DiscordRPC/Configuration.cs Show resolved Hide resolved
@CanadaHonk CanadaHonk requested a review from Lachee November 26, 2022 18:02
@Lachee Lachee merged commit d8c97cc into Lachee:master Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants