FEAT: eject operator #105
Merged
FEAT: eject operator #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -124,6 +130,13 @@ contract LagrangeService is Initializable, OwnableUpgradeable, ILagrangeService | |||
| emit OperatorDeregistered(_operator); | |||
| } | |||
|
|
|||
| /// Owner can eject the operator from the service. | |||
| /// note This function is available only on testnet. | |||
| function ejectOperator(address operator) external onlyOwner onlyTestnet { | |||
There was a problem hiding this comment.
please update the function name like unsubscribeByAdmin, the chainID should be indicated
|
|
||
| modifier onlyWhitelisted() { | ||
| require(operatorWhitelist[msg.sender], "Operator is not whitelisted"); | ||
| _; | ||
| } | ||
|
|
||
| modifier onlyTestnet() { |
There was a problem hiding this comment.
onlyHoleskyTestnet, for the strict match
| @@ -91,6 +91,14 @@ contract LagrangeCommittee is Initializable, OwnableUpgradeable, ILagrangeCommit | |||
| delete operatorsStatus[operator]; | |||
| } | |||
|
|
|||
| // Unsubscribe chain by admin | |||
| function unsubscribeByAdmin(address operator, uint32 chainID) external onlyService { | |||
There was a problem hiding this comment.
Suggested change
| function unsubscribeByAdmin(address operator, uint32 chainID) external onlyService { | |
| function unsubscribeByAdmin(address[] operators, uint32 chainID) external onlyService { |
cool-develope
approved these changes
May 17, 2024
ChainDev931105
added a commit
that referenced
this pull request
Jul 30, 2024
* fix: clean up and add LICENSE (#78) * clean up code * clean build * update license * add audit reports * fix committee.test.js (#79) * revert epoch (#85) * adjust operator count (#84) * add workflow (#89) * feat: update the BLS key and signer address (#88) * allow to update the bls keys and signer address * add tests --------- Co-authored-by: Master Engineer <104206186+mastereng12@users.noreply.github.com> * FEAT: Allow to update epoch period (#93) * epoch_modifi draft * update epoch formula * fix reviewed issues * fix reviewed issues * fix naming of getEpochNumber * epoch period modify unit test (#97) * CHORE: Epoch period modify simulation (#98) * simulation test for epoch period modify * fix issue in redeloy script * format * fix: avoid to remove all bls pub keys (#102) * fix the remove bls keys * more tests * Workflow with solhint (#101) * solhint cli * update solhint checkpoints * Update contracts/protocol/VoteWeigher.sol Co-authored-by: cool-developer <51834436+cool-develope@users.noreply.github.com> --------- Co-authored-by: cool-developer <51834436+cool-develope@users.noreply.github.com> * FEAT: eject operator (#105) * feat eject operator * fix reviewed errors * strengthen test * unsubscribe multiple operators * FEAT: Deploy to Sepolia (#106) * deploy sepolia * testnet deploy script Co-authored-by: cool-developer <51834436+cool-develope@users.noreply.github.com> * add eigen sepolia addresses --------- Co-authored-by: cool-developer <51834436+cool-develope@users.noreply.github.com> * add fork test for rotate and revert (#107) * Docker workflow (#109) * push-docker yml * add permission makefile * push-docker-test * install forge build * remove test yml * CHORE: Script for register chain (#108) * add register chain script * update epoch period * update min/max weight * update genersis block * add basescript * script eject op * [FIX] Register operator sleep (#110) * fix register-operator sleep * remove test yml * archive mode geth (#112) * fix: geth docker cmd (#113) * archive mode geth * fix * [Fix] audited issues (#115) * fix audit issues * add audit report * Make epoch period flexible (#118) * epoch period flexible * test for epoch period flex * add simulation test for flex period * fix epoch period for prior blocks * flow auto release (#127) * add issue templates (#130) * Script - Transfer ownership (#121) * forge install: safe-smart-account 499b17ad0191b575fcadc5cb5b8e3faeae5391ae * script transfer ownership * Override for testnet committee - L1 Block Number (#123) * testnet l1bias override * fix annoying function naming * feat: bls key ownership check (#138) * bls key ownership check * unit test & inherit checker * optimize epoch number search * fork test bls own check * update storage hash --------- Co-authored-by: ChainDev931105 <ethanackerland@gmail.com> * epic sequencer bls key (#140) * Revert "epic sequencer bls key (#140)" (#141) This reverts commit 1e57449. * fix deploy-register (#142) * fix * [FIX] Audit Issues - Main (#149) * Update README.md (#136) * [FIX] script redeploy testnet (#144) * fix script redeploy testnet * fix get_updated_l1_block * solc version 0.8.20, blsKeyChecker issue * digest hash add version field * hardhat solidity version update --------- Co-authored-by: cool-developer <51834436+cool-develope@users.noreply.github.com> --------- Co-authored-by: Master Engineer <104206186+mastereng12@users.noreply.github.com> Co-authored-by: ChainDev <76214877+ChainDev931105@users.noreply.github.com> Co-authored-by: Kashish Shah <kashish@lagrange.dev> Co-authored-by: ChainDev931105 <ethanackerland@gmail.com>
ChainDev931105
added a commit
that referenced
this pull request
Aug 26, 2024
* fix: clean up and add LICENSE (#78) * clean up code * clean build * update license * add audit reports * fix committee.test.js (#79) * revert epoch (#85) * adjust operator count (#84) * add workflow (#89) * feat: update the BLS key and signer address (#88) * allow to update the bls keys and signer address * add tests --------- Co-authored-by: Master Engineer <104206186+mastereng12@users.noreply.github.com> * FEAT: Allow to update epoch period (#93) * epoch_modifi draft * update epoch formula * fix reviewed issues * fix reviewed issues * fix naming of getEpochNumber * epoch period modify unit test (#97) * CHORE: Epoch period modify simulation (#98) * simulation test for epoch period modify * fix issue in redeloy script * format * fix: avoid to remove all bls pub keys (#102) * fix the remove bls keys * more tests * Workflow with solhint (#101) * solhint cli * update solhint checkpoints * Update contracts/protocol/VoteWeigher.sol Co-authored-by: cool-developer <51834436+cool-develope@users.noreply.github.com> --------- Co-authored-by: cool-developer <51834436+cool-develope@users.noreply.github.com> * FEAT: eject operator (#105) * feat eject operator * fix reviewed errors * strengthen test * unsubscribe multiple operators * FEAT: Deploy to Sepolia (#106) * deploy sepolia * testnet deploy script Co-authored-by: cool-developer <51834436+cool-develope@users.noreply.github.com> * add eigen sepolia addresses --------- Co-authored-by: cool-developer <51834436+cool-develope@users.noreply.github.com> * add fork test for rotate and revert (#107) * Docker workflow (#109) * push-docker yml * add permission makefile * push-docker-test * install forge build * remove test yml * CHORE: Script for register chain (#108) * add register chain script * update epoch period * update min/max weight * update genersis block * add basescript * script eject op * [FIX] Register operator sleep (#110) * fix register-operator sleep * remove test yml * archive mode geth (#112) * fix: geth docker cmd (#113) * archive mode geth * fix * [Fix] audited issues (#115) * fix audit issues * add audit report * Make epoch period flexible (#118) * epoch period flexible * test for epoch period flex * add simulation test for flex period * fix epoch period for prior blocks * flow auto release (#127) * add issue templates (#130) * Script - Transfer ownership (#121) * forge install: safe-smart-account 499b17ad0191b575fcadc5cb5b8e3faeae5391ae * script transfer ownership * Override for testnet committee - L1 Block Number (#123) * testnet l1bias override * fix annoying function naming * feat: bls key ownership check (#138) * bls key ownership check * unit test & inherit checker * optimize epoch number search * fork test bls own check * update storage hash --------- Co-authored-by: ChainDev931105 <ethanackerland@gmail.com> * epic sequencer bls key (#140) * Revert "epic sequencer bls key (#140)" (#141) This reverts commit 1e57449. * fix deploy-register (#142) * update readme --------- Co-authored-by: cool-developer <51834436+cool-develope@users.noreply.github.com> Co-authored-by: Master Engineer <104206186+mastereng12@users.noreply.github.com> Co-authored-by: Kashish Shah <kashish@lagrange.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Closes: #104
Reviewers