Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce sound data builder #89

Merged
merged 21 commits into from
Dec 18, 2023
Merged

Conversation

Laguna1989
Copy link
Owner

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (a0c4fd4) 100.00% compared to head (98e6d46) 97.67%.

❗ Current head 98e6d46 differs from pull request most recent head fd26207. Consider uploading reports for the commit fd26207 to get more accurate results

Files Patch % Lines
impl/oalpp/sound_data/sound_data.cpp 28.57% 10 Missing ⚠️
impl/oalpp/sound_data/sound_data_builder.cpp 97.26% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##            master      #89      +/-   ##
===========================================
- Coverage   100.00%   97.67%   -2.33%     
===========================================
  Files           32       25       -7     
  Lines          545      558      +13     
===========================================
  Hits           545      545              
- Misses           0       13      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Laguna1989 Laguna1989 merged commit 5e7e812 into master Dec 18, 2023
8 checks passed
@Laguna1989 Laguna1989 deleted the feature/UseSoundDataBuilder branch December 18, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants