Fixes deadlock in #100 #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue described in #100
I've removed the
source.isRunningcheck which if false would try and stop the audio unit. This did cause deadlocks where a blockingAudioOutputUnitStop-call indellocwould wait for the next callback to finish. When the last callback is run it will also try to callAudioOutputUnitStopifisRunningis set to false. ThisAudioOutputUnitStop-call is not supposed to be blocking while called in the I/O-thread but will be waiting for a mutex created by the call made in dealloc and you've got a deadlock.I've moved the AudioOutputUnitStop to be called directly in the
AudioCapture.running-setter instead.