Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Trust] Add Missing Parameter from PR #2931 #3244

Merged
merged 1 commit into from
Nov 21, 2022
Merged

[Trust] Add Missing Parameter from PR #2931 #3244

merged 1 commit into from
Nov 21, 2022

Conversation

Barthandalus
Copy link
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Corrects error being generated when casting Mumor.
image

Line 65, gambit was missing a parameter causing a break, I missed this on PR #2931 when initially adding these enhancements.

Before and after:
image
image

Steps to test these changes

  1. Load in changes,
  2. Cast Mumor with a main healer job.

@zach2good zach2good changed the title [Trust] Correction | Missing Parameter from PR #2931 [Trust] Add Missing Parameter from PR #2931 Nov 21, 2022
@zach2good
Copy link
Contributor

Pr looks good, I updated the title to remove the pipe character. I've seen lots of people using it as an excuse to stuff unrelated changes together (not relevant here) and I just wanted to make sure it wasn't visible to back up that workflow 👍

@zach2good zach2good merged commit a680157 into LandSandBoat:base Nov 21, 2022
@Barthandalus Barthandalus deleted the mumorCorrection branch November 21, 2022 11:09
TiberonKalkaz pushed a commit to TiberonKalkaz/server that referenced this pull request Nov 8, 2023
TiberonKalkaz pushed a commit to TiberonKalkaz/server that referenced this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants