Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly run module cpp and sql during all CIs. #6295

Closed
wants to merge 2 commits into from

Conversation

clanofartisans
Copy link
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Attempting to resolve the issues Zach outlined in #5347 ~ CPP and SQL module files aren't being run for Full_Startup_Checks_Linux, MultiInstance_Startup_Checks_Linux, or Full_Startup_Checks_Windows.

Steps to test these changes

Run CIs.

@Xaver-DaRed Xaver-DaRed added the squash Reminder to squash commits before/on merge (you can do this, or maintainers will do this for you) label Oct 1, 2024
@Xaver-DaRed
Copy link
Contributor

Xaver-DaRed commented Oct 1, 2024

Don't need to close your PR. The squash lable is so we dont forget to squash the commits

@clanofartisans
Copy link
Contributor Author

Don't need to close your PR. The squash lable is so we dont forget to squash the commits

I messed up and it feels cleaner to redo it. I'm still kinda learning git ; ;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squash Reminder to squash commits before/on merge (you can do this, or maintainers will do this for you)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants