Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Only continue asio sessions inside lambda capture #6458

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

zach2good
Copy link
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

I was doing some reading about ASIO over the weekend and I saw this pattern a lot. Should have no noticeable difference, and theoretically construct 1x less shared_ptr in these cases.

@zach2good zach2good merged commit 74d448a into base Nov 25, 2024
12 of 13 checks passed
@zach2good zach2good deleted the asio_shared_from_this_pattern branch November 25, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants