Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not build the schema registry client if not needed #361

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

cbornet
Copy link
Member

@cbornet cbornet commented Sep 6, 2023

No description provided.

@cbornet cbornet requested a review from eolivelli September 6, 2023 11:09
Copy link
Member

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cbornet cbornet requested a review from eolivelli September 6, 2023 11:21
@cbornet cbornet merged commit 7760d41 into main Sep 6, 2023
@cbornet cbornet deleted the fix-schema-registry-optional branch September 6, 2023 11:36
benfrank241 pushed a commit to vectorize-io/langstream that referenced this pull request May 2, 2024
* Do not build the schema registry client if not needed

* Improve exception when schema.registry.url is missing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants