Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cli: use global config file by default #373

Merged
merged 3 commits into from
Sep 7, 2023
Merged

Conversation

nicoloboschi
Copy link
Member

  • By default, it uses the config file at $HOME/.langstream/config. If it doesn't exist, it gets created.
  • User can still pass --conf to use a different config file
  • conf/cli.yaml is anymore included in the zip/docker since it's not necessary
  • default values are now set by the cli directly instead of being retrieved by the file

This is breaking change since the current config file will be ignored and new one will be used.

Note that the command ´bin/langstream´ is a bit different from the one that you install. The former injects the --conf parameter by using the env LANGSTREAM_CLI_CONF. Now it defaults to the global one as well.
Since that command is likely to be used during development, I added a info at the cli startup

Using global CLI config file. To use the dev config file, set LANGSTREAM_CLI_CONFIG=conf/cli.yaml

@nicoloboschi nicoloboschi force-pushed the use-global-config-file branch from 9f4ad3d to 7d2d171 Compare September 7, 2023 09:42
Copy link
Member

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that conf/cli.yaml is pretty useful.

for local development which values are used ?

Copy link
Member

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eolivelli eolivelli merged commit 7132dcf into main Sep 7, 2023
@eolivelli eolivelli deleted the use-global-config-file branch September 7, 2023 15:18
benfrank241 pushed a commit to vectorize-io/langstream that referenced this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants