[agentrunner] Split the docker image and clean up the logs #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <groupId>io.netty</groupId> | ||
| <artifactId>netty-transport-native-unix-common</artifactId> | ||
| <version>${netty.version}</version> | ||
| </dependency> |
There was a problem hiding this comment.
this is commented code
| @@ -58,8 +27,8 @@ ENV NLTK_DATA="/app/nltk_data" | |||
|
|
|||
| # Install python runtime deps | |||
| RUN cd /app && pipenv requirements --categories="packages full" > /app/requirements.txt \ | |||
| && python3 -m pip install -r /app/requirements.txt \ | |||
| && python3 -m nltk.downloader -d /app/nltk_data punkt averaged_perceptron_tagger | |||
| && python3 -m pip install -r /app/requirements.txt \ | |||
There was a problem hiding this comment.
since this stuff takes a lot and it's likely to never change during development, can we put it in the base image ?
There was a problem hiding this comment.
but we cannot do it
because of this line, that depends on the langstream-runtime build (the "maven" directory)
ADD maven/Pipfile.lock /app/Pipfile.lock
cc @cbornet
There was a problem hiding this comment.
I think we should isolate the python stuff in it’s own maven subproject.
nicoloboschi
approved these changes
Sep 13, 2023
benfrank241
pushed a commit
to vectorize-io/langstream
that referenced
this pull request
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changes to the docker images:
Changes to logging: