-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[breaking change] Do not use Mustache but SpringBoot like references to refer to secrets and globals #507
Conversation
langstream-core/src/main/java/ai/langstream/impl/common/ApplicationPlaceholderResolver.java
Outdated
Show resolved
Hide resolved
langstream-core/src/main/java/ai/langstream/impl/common/ApplicationPlaceholderResolver.java
Outdated
Show resolved
Hide resolved
@@ -400,7 +400,7 @@ private ApplicationCustomResource createAppWithResources( | |||
metadata: | |||
name: %s | |||
spec: | |||
application: '{"agentRunners": {"agent1": {"resources": {"size": %d, "parallelism": %d}}}}' | |||
application: '{"agentRunners": {"agent1": {"resources": {"size": %d, "parallelism": %d}}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is unrelated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
@@ -124,7 +124,7 @@ private ApplicationCustomResource createApp(String tenant, int size, int paralle | |||
name: %s | |||
namespace: %s | |||
spec: | |||
application: '{"agentRunners": {"agent1": {"resources": {"size": %d, "parallelism": %d}}}}' | |||
application: '{"agentRunners": {"agent1": {"resources": {"size": %d, "parallelism": %d}}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unrelated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
…to refer to secrets and globals (LangStream#507)
Problems statement:
This nesting of Mustache templates is really awkward and the use must use a strange '{{%' syntax in Prompts and Queries.
Modifications: