Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dry-run apps deployment #533

Merged
merged 4 commits into from
Oct 6, 2023
Merged

Add dry-run apps deployment #533

merged 4 commits into from
Oct 6, 2023

Conversation

nicoloboschi
Copy link
Member

Fixes #532

Changes:

  • New option in the deploy langstream apps deploy --dry-run my-app -app .... This sends a request to the control plane.
  • The control plane handles the new option and generates the application description with the resolved application. The app is not deployed
  • You can customize the output with -o yaml/json. By default is yaml
  • The same option is not recognized for the update command since we don't want to expose already stored secrets to the user (that might not have access to them)

Copy link
Member

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

Can you please add this option also in the "docker run" mode ?
People that are used to use "docker run" don't have a control plane running

@eolivelli eolivelli self-requested a review October 5, 2023 11:16
@eolivelli
Copy link
Member

LGTM as far as we add support for "docker run" users.

@eolivelli eolivelli dismissed their stale review October 5, 2023 11:17

I don't want to block the PR

@nicoloboschi nicoloboschi merged commit 87e3ea5 into main Oct 6, 2023
8 checks passed
@nicoloboschi nicoloboschi deleted the cli-dry-run branch October 6, 2023 07:22
benfrank241 pushed a commit to vectorize-io/langstream that referenced this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cli: add command to resolve placeholders locally
2 participants