Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pulsar runtime depency conflicts #580

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Fix pulsar runtime depency conflicts #580

merged 1 commit into from
Oct 13, 2023

Conversation

cbornet
Copy link
Member

@cbornet cbornet commented Oct 13, 2023

NB: this makes Pulsar not working anymore with Avro manipulating agents. But without this Pulsar doesn't work at all.
We can fix the problem with Avro later.

@cbornet cbornet requested a review from eolivelli October 13, 2023 10:40
@cbornet
Copy link
Member Author

cbornet commented Oct 13, 2023

Other NB: trying to use non-shaded versions for both the admin and the client doesn't work bc of some weird issue in the class loading.

Copy link
Member

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@eolivelli eolivelli merged commit 05408d1 into main Oct 13, 2023
9 checks passed
@eolivelli eolivelli deleted the fix-pulsar branch October 13, 2023 11:54
benfrank241 pushed a commit to vectorize-io/langstream that referenced this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants