Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gateway with Pulsar #586

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Fix gateway with Pulsar #586

merged 1 commit into from
Oct 13, 2023

Conversation

cbornet
Copy link
Member

@cbornet cbornet commented Oct 13, 2023

No description provided.

@cbornet cbornet force-pushed the pulsar-gateway branch 2 times, most recently from cf31a71 to 18e9128 Compare October 13, 2023 19:40
Copy link
Member

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

The only thing that I am not sure is that on the Producer we enforce a String schema on the topic.
As the topic is in theory schemaless we should keep BYTES. But we can address it in a follow up work

@cbornet
Copy link
Member Author

cbornet commented Oct 13, 2023

You're right. It should be BYTES.
The other concern I have is whether the read MessageId contains the info for all partitions.

@eolivelli eolivelli merged commit 7b9c244 into main Oct 13, 2023
9 checks passed
@eolivelli eolivelli deleted the pulsar-gateway branch October 13, 2023 20:36
@eolivelli
Copy link
Member

We have to add test cases for partitioned topics. I guess we have to manually keep track of each partition

@cbornet
Copy link
Member Author

cbornet commented Oct 15, 2023

The only thing that I am not sure is that on the Producer we enforce a String schema on the topic.
As the topic is in theory schemaless we should keep BYTES

We can do like Kafka and wait for the first message to infer the schema type based on the Java type. I'll do it.

benfrank241 pushed a commit to vectorize-io/langstream that referenced this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants