Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helper scripts to set the REACT_APP environment variables #614

Merged
merged 4 commits into from
Oct 19, 2023

Conversation

cdbartholomew
Copy link
Member

Most of the the environment variable settings to use the React UI can be determined from langstream CLI outputs. I added a couple of helper scripts and some instructions in the README to make it easier to properly set the env vars.

@eolivelli
Copy link
Member

@cdbartholomew can you please run

mvn generate-sources

in order to fix the style issues ?

Copy link
Member

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eolivelli
Copy link
Member

I have rebased on top of main branch. The patch is good to go as soon as CI passes

@eolivelli eolivelli merged commit 9d31239 into main Oct 19, 2023
8 of 9 checks passed
@eolivelli eolivelli deleted the react-env-scripts branch October 19, 2023 13:22
benfrank241 pushed a commit to vectorize-io/langstream that referenced this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants