Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: fix temp file permissions #629

Merged
merged 4 commits into from
Oct 20, 2023
Merged

CLI: fix temp file permissions #629

merged 4 commits into from
Oct 20, 2023

Conversation

nicoloboschi
Copy link
Member

@nicoloboschi nicoloboschi commented Oct 20, 2023

After the recent changes on 0.3.0, the temporary directory containing the application is only readable (not executable). UNIX permissions require the "execute" permission on a directory to perform listing

Since on Mac copying the app directory is not needed, we only perform the copy on linux

Copy link
Member

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I have left a comment

@nicoloboschi nicoloboschi merged commit 08b9c1c into main Oct 20, 2023
8 of 9 checks passed
@nicoloboschi nicoloboschi deleted the fix-permissions branch October 20, 2023 09:19
benfrank241 pushed a commit to vectorize-io/langstream that referenced this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants