Add persistent state directory to python agents #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
requested changes
Oct 25, 2023
langstream-runtime/langstream-runtime-impl/src/main/python/Pipfile
Outdated
Show resolved
Hide resolved
|
|
||
| class Agent(ABC): | ||
| """The Agent interface""" | ||
|
|
||
| def init(self, config: Dict[str, Any]): | ||
| def init(self, config: Dict[str, Any], context: AgentContext): |
There was a problem hiding this comment.
is this a breaking change ?
maybe we should have same approach as in Java and have a "setAgentContext" function
There was a problem hiding this comment.
no it is not, I added a test for the old syntax
| print("Missing gRPC target and python class name") | ||
| print("usage: python -m langstream_grpc <target> <config>") | ||
| sys.exit(1) | ||
|
|
||
| server = AgentServer(sys.argv[1], sys.argv[2]) | ||
| context_config = {} | ||
| if len(sys.argv) > 3: |
There was a problem hiding this comment.
the process is always launched by the same version of the java runtime, there is no need to do this
cbornet
reviewed
Oct 25, 2023
langstream-runtime/langstream-runtime-impl/src/main/python/langstream_grpc/api.py
Outdated
Show resolved
Hide resolved
cbornet
reviewed
Oct 25, 2023
langstream-runtime/langstream-runtime-impl/src/main/python/langstream_grpc/grpc_service.py
Outdated
Show resolved
Hide resolved
cbornet
reviewed
Oct 25, 2023
langstream-runtime/langstream-runtime-impl/src/main/python/langstream_grpc/api.py
Show resolved
Hide resolved
|
LGTM. Just some minor comments. |
Thanks I addressed your comments |
eolivelli
approved these changes
Oct 25, 2023
benfrank241
pushed a commit
to vectorize-io/langstream
that referenced
this pull request
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
if the agent declares init with only argument, it works as before