Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Add support for hot reload of python code in docker mode #654

Merged
merged 8 commits into from
Oct 26, 2023

Conversation

eolivelli
Copy link
Member

@eolivelli eolivelli commented Oct 26, 2023

Summary:

When you are working locally, add the ability to automatically reload python code without restarting the container

In "docker run" mode the cli start watching on the python files.
In case of any python file that has changed the python agent is restarted, picking up the new version of the code.

The is a new flag "--watch-files=false" to disable the feature.

The watcher starts only if there is a "python" directory in the application

Follow up:

  • if there is a syntax error the Python process crashes, so the docker container exists
  • add test cases

@eolivelli eolivelli changed the title [python] Add support for hot reload of code in docker mode [python] Add support for hot reload of code in docker mode - part 1 Oct 26, 2023
@eolivelli eolivelli marked this pull request as ready for review October 26, 2023 13:11
@eolivelli eolivelli changed the title [python] Add support for hot reload of code in docker mode - part 1 [python] Add support for hot reload of python code in docker mode - part 1 Oct 26, 2023
@eolivelli eolivelli requested a review from cbornet October 26, 2023 13:46
@eolivelli eolivelli changed the title [python] Add support for hot reload of python code in docker mode - part 1 [python] Add support for hot reload of python code in docker mode Oct 26, 2023
@eolivelli eolivelli merged commit eec9581 into main Oct 26, 2023
10 checks passed
@eolivelli eolivelli deleted the impl/docker-python-reload branch October 26, 2023 16:32
benfrank241 pushed a commit to vectorize-io/langstream that referenced this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants