Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[langserve-invoke] Extract the LangServe Java Client code and Allow to parse simple strings and not only JSON #676

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

eolivelli
Copy link
Member

@eolivelli eolivelli commented Nov 1, 2023

Summary:

  • handle String content
  • extract the code of the Java LangServeClient
  • add tests

Copy link
Member

@nicoloboschi nicoloboschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
adding a unit test would be better

@eolivelli eolivelli changed the title [langserve-invoke] Allow to parse simple strings and not only JSON [langserve-invoke] Extract the LangServe Java Client code and Allow to parse simple strings and not only JSON Nov 2, 2023
@eolivelli eolivelli merged commit fea2bad into main Nov 2, 2023
10 checks passed
@eolivelli eolivelli deleted the impl/langserve-invoke-2 branch November 2, 2023 10:24
benfrank241 pushed a commit to vectorize-io/langstream that referenced this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants