Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix service gateway with topics #683

Merged
merged 7 commits into from
Nov 3, 2023
Merged

Fix service gateway with topics #683

merged 7 commits into from
Nov 3, 2023

Conversation

nicoloboschi
Copy link
Member

@nicoloboschi nicoloboschi commented Nov 3, 2023 •
edited
Loading

Changes:

  • Invert input and output topic as expected
  • add fixed header langstream-service-request-id to ensure getting the response to the previously sent message
  • Http gateways now by default expects a plain/text that will be part the message value. By passing Content-Type application/json you can still pass the entire body
  • improved tests

eolivelli
eolivelli approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicoloboschi nicoloboschi merged commit f3de246 into main Nov 3, 2023
10 checks passed
@nicoloboschi nicoloboschi deleted the fix-service-gateway branch November 3, 2023 12:10
benfrank241 pushed a commit to vectorize-io/langstream that referenced this pull request May 2, 2024
@nicoloboschi
Fix service gateway with topics (LangStream#683)
d0d514b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eolivelli eolivelli eolivelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicoloboschi @eolivelli