Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apps: implement force deletion and improve status #714

Merged
merged 9 commits into from
Nov 15, 2023

Conversation

nicoloboschi
Copy link
Member

Changes:

  • If the deployer/setup job during deploy or deletion fails, we now report the error in the application status
  • There's a new option in the deletion -f, to skip cleanup errors and go ahead with the application deletion

Implementation:

  • There's a new field in the application crd that handles wether the application can skip the cleanup or not in case of failures (only 1 attempt).
  • The deletion process totally changes:
    • Before: the control plane deletes the app CRD and the finalizer is triggered in the operator. This triggers the cleanup and in case of failures, nothing can be done.
    • Now: the control plane puts a flag "marked for deletion" in the crd specs. In this way it's then possible to force the deletion of the app after the app failed to be deleted. This was not possible before because once you delete a custom resource, you cannot change his config. So now the operator reacts to this new flag by starting the deletion process, handling errors reading the new skipErrors flag. Once done, it finally deletes the custom resource. The finalizer is still there to verify the cleanup ran and to update the tenant resource usage, but now it's much more lightweight.

Copy link
Member

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

very nice !

@nicoloboschi nicoloboschi merged commit 54d8aef into main Nov 15, 2023
10 checks passed
@nicoloboschi nicoloboschi deleted the app-delete-forice branch November 15, 2023 09:04
benfrank241 pushed a commit to vectorize-io/langstream that referenced this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants