Add topic producer API Python side #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbornet
commented
Nov 21, 2023
| """Write a record to a topic (for async methods).""" | ||
| pass | ||
|
|
||
| def write_future(self, topic: str, record: Record) -> Future: |
There was a problem hiding this comment.
Suggestions for a better name ?
There was a problem hiding this comment.
what about "awrite" for the async write and "write" for the sync version ?
There was a problem hiding this comment.
Yes, I've thought of that. Now both methods are kinda "async", one with async/await, the other with Future.
There was a problem hiding this comment.
But let's use awrite as it's a defacto convention when 2 methods do the same thing and one does it on the event loop.
cbornet
force-pushed
the
python-topic-producer-python-side
branch
from
2bef373 to
c140c87
Compare
cbornet
force-pushed
the
python-topic-producer-python-side
branch
from
c140c87 to
07d9cab
Compare
benfrank241
pushed a commit
to vectorize-io/langstream
that referenced
this pull request
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #649
After that, remaining work for topic producer will be: