refactor: Remove redundant default-constructor factory for Nav delega…

…te (acts-project#2741) The default constructor of `Delegate` already produces an unconnected delegate.
LaraCalic · Feb 10, 2024 · 9453b9e · 9453b9e
1 parent 1402b41
commit 9453b9e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 9 deletions.
diff --git a/Core/include/Acts/Detector/Portal.hpp b/Core/include/Acts/Detector/Portal.hpp
@@ -132,8 +132,8 @@ class Portal {
   std::shared_ptr<RegularSurface> m_surface;
 
   /// The portal targets along/opposite the normal vector
-  DetectorVolumeUpdaters m_volumeUpdaters = {unconnectedUpdater(),
-                                             unconnectedUpdater()};
+  DetectorVolumeUpdaters m_volumeUpdaters = {DetectorVolumeUpdater{},
+                                             DetectorVolumeUpdater{}};
 
   /// The portal attaches to the following volumes
   AttachedDetectorVolumes m_attachedVolumes;

diff --git a/Core/include/Acts/Navigation/NavigationDelegates.hpp b/Core/include/Acts/Navigation/NavigationDelegates.hpp
@@ -55,12 +55,5 @@ using DetectorVolumeUpdater =
     OwningDelegate<void(const GeometryContext& gctx, NavigationState& nState),
                    INavigationDelegate>;
 
-/// @brief  A dummy constructed updator
-inline static DetectorVolumeUpdater unconnectedUpdater() {
-  DetectorVolumeUpdater unconnected;
-  unconnected.disconnect();
-  return unconnected;
-}
-
 }  // namespace Experimental
 }  // namespace Acts