do not add order by primary key if there are group by in the query #5608
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
BEFORE - What was wrong? What was happening before this PR?
Reported in Laravel-Backpack/community-forum#1107
In some rdms with
sql_mode=only_full_group_by
enabled, adding the primary key order resulted in an error, as theid
column was not part of thegroup by
clause.In that regard,
id
never makes sense as part of agroup by
clause, as it should always be unique anyway.AFTER - What is happening after this PR?
If there is a
group by
in the query we don't apply the defaultorder by id
.