Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Minimise files on production? #86

Closed
fronbow opened this issue Aug 21, 2023 · 1 comment
Closed

[Feature request] Minimise files on production? #86

fronbow opened this issue Aug 21, 2023 · 1 comment

Comments

@fronbow
Copy link

fronbow commented Aug 21, 2023

Hi All

I've been contemplating adding this (https://github.com/matthiasmullie/minify) into the basset pipeline - it's in the back of my head for when I get a spare moment!
I've noticed there's quite a bit of overhead with the amount of files that get basset-ed so wondering whether there's any mileage in minimising the styles and scripts in a production environment, or maybe even adding a command switch to the basset command to force minimisation so the developer could do @basset('https://cdn.com/path/to/file.js', 'minimise=true') or somesuch.

I was also wondering if there's any mileage in concatenation - I seem to remember something like this in WordPress or drupal (can't remember which as it's been a while since I've been over their sides!!) where you could state when a script or style relied on another like jquery and they would be concatenated in a specific order - obviously not for all files, just the global stuff, but what's the general consensus?

Cheers

@tabacitu
Copy link
Member

tabacitu commented Aug 21, 2023

Hey @fronbow - this should be possible to do, as a dev, if we do #85 - that idea came out of the same need. So let's move the conversation there.

But regarding your question... this might make sense if you have a lot of custom CSS and JS. But the CSS and JS Backpack uses is already minified. So the benefit would be minimal, if you ask me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants