-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add basset() helper function #85
Feat: Add basset() helper function #85
Conversation
Return whenever the output is DISABLED or INVALID
Hey @MrMohamedAbdallah, thank you for the PR 👌 |
Hi @promatik , I wanted to add tests but I was blocked by the helper function in Pest with the same name. I also wanted to add a feature to cache the result when the user run |
Ouch! Those are valid concerns @MrMohamedAbdallah :
I'll ask @promatik to take a look this week or the next. Right now I know he's working on a feature. |
Yes, I'll take a look at it, we'll need to rename the current pest helper 👌 there's no issue on doing that, it's no a BC. |
Replaced current pest basset helper
Ok! So this one is ready from my side 👌
|
This. Is. AWESOME! I'm super-excited, thanks a lot for this @MrMohamedAbdallah & @promatik . I've just pushed a change to the README file in this PR. I've documented this new @promatik please take a look at Pedro's mention on https://github.com/Laravel-Backpack/basset/pull/85/files#r1307011614 - other than that I have nothing to say on this, let's merge, tag and release as Basset 1.2.0 💪 |
Co-authored-by: Cristian Tăbăcitu <cristian.tabacitu@digitallyhappy.com>
Added
basset
helper function mentioned in #83.For testing, the helper function name conflicts with the helper function defined in
tests/Pest.php
.