HOT-FIX - backward compatible @loadOnce directive #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last PR we merged introduced a BC.
@loadOnce is not used anywhere since we switched to basset, but people upgraded their apps and didn't remove the @loadOnce directive like we did in all our files (most of it).
I don't know why it was not marked as a BC when we launched v6. No real benefit, would be just a search and replace
@loadOnce()for@bassetor@bassetBlock🤷Now it's late, I've marked it as deprecated and we will completely remove it to avoid this kind of issues in the future. There is not a single benefit of keeping @loadOnce. Only downsides as it does not fully support what basset do.