Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to set some configurations from .env file #343

Merged
merged 3 commits into from
Nov 18, 2023
Merged

Ability to set some configurations from .env file #343

merged 3 commits into from
Nov 18, 2023

Conversation

mohamedsabil83
Copy link
Member

No description provided.

andrey-helldar
andrey-helldar approved these changes Nov 18, 2023
View reviewed changes
Copy link
Member

@andrey-helldar andrey-helldar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a "fool-proof" I added an explicit conversion to a boolean type since the env function doesn't always do the job, which has been tested in practice.

In principle, I agree with these changes.

config/public.php Outdated Show resolved Hide resolved
config/public.php Outdated Show resolved Hide resolved
@andrey-helldar andrey-helldar merged commit 391086a into Laravel-Lang:main Nov 18, 2023
4 of 5 checks passed
@andrey-helldar
Copy link
Member

شكراً لك

@mohamedsabil83
Copy link
Member Author

Пожалуйста

@mohamedsabil83
Copy link
Member Author

As a "fool-proof" I added an explicit conversion to a boolean type since the env function doesn't always do the job, which has been tested in practice.

In principle, I agree with these changes.

Agreed. Good addition.

@mohamedsabil83 mohamedsabil83 deleted the use-dot-env branch November 18, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrey-helldar andrey-helldar andrey-helldar approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mohamedsabil83 @andrey-helldar