Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby on Rails capstone project - Pennywise #5

Merged
merged 19 commits into from
Sep 2, 2023
Merged

Ruby on Rails capstone project - Pennywise #5

merged 19 commits into from
Sep 2, 2023

Conversation

LarryIVC
Copy link
Owner

@LarryIVC LarryIVC commented Sep 2, 2023

In this pull request, I did the following:

  • ✅ Added functionality to register, and login users using the devise gem.
  • ✅ Added models, Group as Categories, Expense as Transaction and User.
  • ✅ Added view for Categories.
  • The user can show the categories.
  • User can add new categories.
  • User can destroy category.
  • The user can show the amount of total transaction and the amount for each category.
  • ✅ Added view for transactions.
  • User can show all transactions for a category.
  • The user can add a new transaction.
  • The user can destroy any transaction.
  • The user can show the total amount for the current category.
  • ✅ Added styles according to design guidelines.
  • Colors.
  • Typography.
  • Layout composition.
  • ✅ Added a Home page.
  • The user should be able to register in the app with full name, email, and password
  • The user can log into the app using email and password.
  • If the user is not logged in, they can't access pages that require the user to be logged in.

Thanks.

Copy link

@binhussen binhussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @LarryIVC ,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
IApproveSimonCowellGIF (5)

Highlights

  • STicked Given Design✔️
  • Well Structured Code ✔️
  • Used Git flow ✔️

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@LarryIVC
Copy link
Owner Author

LarryIVC commented Sep 2, 2023

Thanks @binhussen, Have a good day.

@LarryIVC LarryIVC merged commit 7135ab1 into main Sep 2, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants