Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version not displayed in created CIF file #14

Closed
Cs137 opened this issue Jan 12, 2023 · 1 comment
Closed

Version not displayed in created CIF file #14

Cs137 opened this issue Jan 12, 2023 · 1 comment

Comments

@Cs137
Copy link

Cs137 commented Jan 12, 2023

Hi Laurent,

many thanks for your nice package!

I recognised that the version field in a created CIF file is a not treated as it should. The variable name is not replaced with an actual version number, the output in the "cite" section of the created file looks as follows (version 1.6.1):

# File generated by `crystals` {__version__}, documented at https://crystals.rtfd.io
# Reference:  L. P. René de Cotret et al, An open-source software ecosystem for the interactive exploration
#             of ultrafast electron scattering data, Advanced Structural and Chemical Imaging 4:11 (2018) DOI: 10.1186/s40679-018-0060-y.

Cheers,
Christian

LaurentRDC added a commit that referenced this issue Jan 13, 2023
@LaurentRDC
Copy link
Owner

The appropriate crystals version will be correctly included in CIFs in version 1.6.2 and beyond, which is being released today. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants