Fix toggling hit animations on the editor not applying immediately

Lawtrohux · May 12, 2022 · 10e41d0 · 10e41d0
1 parent 5f2d9bf
commit 10e41d0
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/osu.Game.Rulesets.Osu/Edit/DrawableOsuEditorRuleset.cs b/osu.Game.Rulesets.Osu/Edit/DrawableOsuEditorRuleset.cs
@@ -6,6 +6,7 @@
 using osu.Framework.Allocation;
 using osu.Framework.Bindables;
 using osu.Framework.Graphics;
+using osu.Framework.Lists;
 using osu.Game.Beatmaps;
 using osu.Game.Configuration;
 using osu.Game.Rulesets.Mods;
@@ -46,15 +47,23 @@ public OsuEditorPlayfield()
                 HitPolicy = new AnyOrderHitPolicy();
             }
 
+            private readonly WeakList<DrawableHitObject> drawableHitObjects = new WeakList<DrawableHitObject>();
+
             [BackgroundDependencyLoader]
             private void load(OsuConfigManager config)
             {
                 hitAnimations = config.GetBindable<bool>(OsuSetting.EditorHitAnimations);
+                hitAnimations.BindValueChanged(_ =>
+                {
+                    foreach (var d in drawableHitObjects) d.RefreshStateTransforms();
+                });
             }
 
             protected override void OnNewDrawableHitObject(DrawableHitObject d)
             {
                 d.ApplyCustomUpdateState += updateState;
+
+                drawableHitObjects.Add(d);
             }
 
             private void updateState(DrawableHitObject hitObject, ArmedState state)

diff --git a/osu.Game/Rulesets/Objects/Drawables/DrawableHitObject.cs b/osu.Game/Rulesets/Objects/Drawables/DrawableHitObject.cs
@@ -448,7 +448,7 @@ private void clearExistingStateTransforms()
         /// <summary>
         /// Reapplies the current <see cref="ArmedState"/>.
         /// </summary>
-        protected void RefreshStateTransforms() => updateState(State.Value, true);
+        public void RefreshStateTransforms() => updateState(State.Value, true);
 
         /// <summary>
         /// Apply (generally fade-in) transforms leading into the <see cref="HitObject"/> start time.