Merge pull request ppy#18237 from peppy/editor-animation-toggle-refre…

…sh-immediately Fix toggling hit animations on the editor not applying immediately
Lawtrohux · May 12, 2022 · c3d4723 · c3d4723
2 parents b48308e + f5649b9
commit c3d4723
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/osu.Game.Rulesets.Osu/Edit/DrawableOsuEditorRuleset.cs b/osu.Game.Rulesets.Osu/Edit/DrawableOsuEditorRuleset.cs
@@ -50,6 +50,11 @@ public OsuEditorPlayfield()
             private void load(OsuConfigManager config)
             {
                 hitAnimations = config.GetBindable<bool>(OsuSetting.EditorHitAnimations);
+                hitAnimations.BindValueChanged(_ =>
+                {
+                    foreach (var d in HitObjectContainer.AliveObjects)
+                        d.RefreshStateTransforms();
+                });
             }
 
             protected override void OnNewDrawableHitObject(DrawableHitObject d)

diff --git a/osu.Game/Rulesets/Objects/Drawables/DrawableHitObject.cs b/osu.Game/Rulesets/Objects/Drawables/DrawableHitObject.cs
@@ -448,7 +448,7 @@ private void clearExistingStateTransforms()
         /// <summary>
         /// Reapplies the current <see cref="ArmedState"/>.
         /// </summary>
-        protected void RefreshStateTransforms() => updateState(State.Value, true);
+        public void RefreshStateTransforms() => updateState(State.Value, true);
 
         /// <summary>
         /// Apply (generally fade-in) transforms leading into the <see cref="HitObject"/> start time.