Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'style' instead of deprecated 'sld' parameter #241

Merged
merged 3 commits into from
Feb 9, 2021

Conversation

index-git
Copy link
Collaborator

@index-git index-git commented Feb 9, 2021

Part of #154

  • Tests
  • Layman Test Client
  • Changlelog
  • Documentation

@index-git index-git added the enhancement New feature or request label Feb 9, 2021
@index-git index-git added this to the Release 1.10 milestone Feb 9, 2021
@index-git index-git requested a review from jirik February 9, 2021 08:49
@index-git index-git self-assigned this Feb 9, 2021
doc/rest.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
doc/rest.md Show resolved Hide resolved
doc/rest.md Outdated Show resolved Hide resolved
src/layman/layer/rest_layer_test.py Outdated Show resolved Hide resolved
@index-git index-git force-pushed the rename-sld-parameter-to-style branch from 60134af to 4346bad Compare February 9, 2021 09:59
CHANGELOG.md Outdated
@@ -16,6 +16,7 @@
- [#99](https://github.com/jirik/layman/issues/99) New endpoint [`/rest/about/version'](doc/rest.md#get-version). Also available in Layman Test Client.
- [#154](https://github.com/jirik/layman/issues/154) Workspace name can not end with '_wms'. In such case, error with code 45 is raised.
- New environment variables [LAYMAN_QGIS_HOST](doc/env-settings.md#LAYMAN_QGIS_HOST), [LAYMAN_QGIS_PORT](doc/env-settings.md#LAYMAN_QGIS_PORT), and [LAYMAN_QGIS_PATH](doc/env-settings.md#LAYMAN_QGIS_PATH).
- [#154](https://github.com/jirik/layman/issues/154) For endpoints [POST Layers](doc/rest.md#post-layers) and [PATCH Layer](doc/rest.md#patch-layer), parameter *sld* is replaced by the new parameter *style* and marked as deprecated. In response to endpoint [GET Layer](doc/rest.md#get-layer), *sld* is replaced by the new *style* item and marked as deprecated.
Copy link
Member

@jirik jirik Feb 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PATCH Layer and DELETE Layer responses should be also mentioned

CHANGELOG.md Outdated
@@ -17,6 +17,7 @@
- [#154](https://github.com/jirik/layman/issues/154) Workspace name can not end with '_wms'. In such case, error with code 45 is raised.
- New environment variables [LAYMAN_QGIS_HOST](doc/env-settings.md#LAYMAN_QGIS_HOST), [LAYMAN_QGIS_PORT](doc/env-settings.md#LAYMAN_QGIS_PORT), and [LAYMAN_QGIS_PATH](doc/env-settings.md#LAYMAN_QGIS_PATH).
- [#154](https://github.com/jirik/layman/issues/154) For endpoints [POST Layers](doc/rest.md#post-layers) and [PATCH Layer](doc/rest.md#patch-layer), parameter *sld* is replaced by the new parameter *style* and marked as deprecated. In response to endpoint [GET Layer](doc/rest.md#get-layer), *sld* is replaced by the new *style* item and marked as deprecated.
- [#154](https://github.com/jirik/layman/issues/154) Maps with URLs pointing to any layer stored in GeoServer are rewritten to dedicated [WMS workspace](doc/data-storage.md#geoserver).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be in Migrations part

@index-git index-git force-pushed the rename-sld-parameter-to-style branch from 4346bad to b945d25 Compare February 9, 2021 10:11
@index-git index-git force-pushed the rename-sld-parameter-to-style branch from b945d25 to 9d29fec Compare February 9, 2021 10:15
@jirik jirik merged commit 9810eb5 into master Feb 9, 2021
@jirik jirik deleted the rename-sld-parameter-to-style branch February 11, 2021 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants