Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

703-Add db_connection param to POST Workspace Layers #734

Merged
merged 10 commits into from
Jan 12, 2023
Merged

703-Add db_connection param to POST Workspace Layers #734

merged 10 commits into from
Jan 12, 2023

Conversation

index-git
Copy link
Collaborator

@index-git index-git commented Jan 5, 2023 •
edited
Loading

Part of issue #703

  • Tests
  • Layman Test Client
  • Changelog
  • Documentation

Optionally

  • Add dependency to doc/dependencies.md

@index-git index-git added this to the Release 1.19 milestone Jan 5, 2023
@index-git index-git force-pushed the 703-db_connection-input-param branch 2 times, most recently from 65d457f to ff83c34 Compare January 6, 2023 09:02
@index-git index-git marked this pull request as ready for review January 6, 2023 09:07
@index-git index-git self-assigned this Jan 6, 2023
@index-git index-git requested a review from jirik January 6, 2023 09:30
@index-git index-git changed the title Add db_connection param to POST Workspace Layers 703-Add db_connection param to POST Workspace Layers Jan 6, 2023
jirik
jirik requested changes Jan 6, 2023
View reviewed changes
src/layman/layer/rest_workspace_layers.py Outdated Show resolved Hide resolved
src/layman/layer/rest_workspace_layers.py Outdated Show resolved Hide resolved
src/layman/layer/util.py Outdated Show resolved Hide resolved
test_tools/process_client.py Outdated Show resolved Hide resolved
src/layman/layer/rest_workspace_layers.py Outdated Show resolved Hide resolved
src/layman/layer/rest_workspace_layers.py Outdated Show resolved Hide resolved
src/layman/layer/rest_workspace_layers.py Outdated Show resolved Hide resolved
src/layman/layer/rest_workspace_layers.py Show resolved Hide resolved
tests/dynamic_data/publications/wrong_input/__init__.py Show resolved Hide resolved
tests/dynamic_data/publications/wrong_input/__init__.py Outdated Show resolved Hide resolved
@index-git index-git force-pushed the 703-db_connection-input-param branch from ff83c34 to 252b4ae Compare January 6, 2023 11:57
jirik
jirik requested changes Jan 6, 2023
View reviewed changes
doc/rest.md Outdated Show resolved Hide resolved
doc/rest.md Outdated Show resolved Hide resolved
doc/rest.md Show resolved Hide resolved
doc/rest.md Outdated Show resolved Hide resolved
@index-git index-git force-pushed the 703-db_connection-input-param branch from 252b4ae to a424340 Compare January 6, 2023 13:32
@index-git index-git modified the milestones: Release 1.19, Release 1.20 Jan 9, 2023
@index-git index-git force-pushed the 703-db_connection-input-param branch 3 times, most recently from 01e39ec to 481210d Compare January 11, 2023 10:36
@index-git index-git force-pushed the 703-db_connection-input-param branch from 481210d to 8737f79 Compare January 11, 2023 12:58
@index-git index-git changed the base branch from 703-master to master January 11, 2023 12:59
@index-git index-git requested a review from jirik January 11, 2023 13:15
jirik
jirik requested changes Jan 11, 2023
View reviewed changes
src/db/util.py Outdated Show resolved Hide resolved
src/db/util.py Outdated Show resolved Hide resolved
src/db/util_test.py Outdated Show resolved Hide resolved
src/db/util.py Outdated Show resolved Hide resolved
@index-git index-git force-pushed the 703-db_connection-input-param branch 2 times, most recently from 5010744 to e45a0e0 Compare January 12, 2023 09:28
@index-git index-git force-pushed the 703-db_connection-input-param branch from e45a0e0 to f61cbae Compare January 12, 2023 09:33
@index-git index-git force-pushed the 703-db_connection-input-param branch from f61cbae to 8575f80 Compare January 12, 2023 10:21
jirik
jirik requested changes Jan 12, 2023
View reviewed changes
doc/rest.md Outdated Show resolved Hide resolved
src/layman/layer/util.py Outdated Show resolved Hide resolved
src/layman/layer/util.py Outdated Show resolved Hide resolved
src/layman/layer/util_test.py Outdated Show resolved Hide resolved
src/layman/layer/util_test.py Outdated Show resolved Hide resolved
src/layman/layer/util_test.py Outdated Show resolved Hide resolved
src/layman/layer/util_test.py Outdated Show resolved Hide resolved
src/layman/layer/util_test.py Outdated Show resolved Hide resolved
src/layman/layer/util_test.py Outdated Show resolved Hide resolved
tests/dynamic_data/publications/wrong_input/__init__.py Outdated Show resolved Hide resolved
@index-git index-git enabled auto-merge (rebase) January 12, 2023 10:22
@index-git index-git merged commit 9e5aced into master Jan 12, 2023
@index-git index-git deleted the 703-db_connection-input-param branch January 12, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jirik jirik jirik approved these changes

Assignees

@index-git index-git

Labels
None yet
Projects
None yet
Milestone
Release 1.20
Development

Successfully merging this pull request may close these issues.
2 participants
@index-git @jirik