Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: operator set migration-2-create quorum #287

Merged

Conversation

stevennevins
Copy link
Collaborator

No description provided.

@stevennevins stevennevins changed the base branch from feat/operatorsets-steven to feat/migration July 25, 2024 13:04
@stevennevins stevennevins changed the title feat: create quorum post operator set migration feat: operator set migration-2-create quorum post operator set migration Jul 26, 2024
@stevennevins stevennevins changed the title feat: operator set migration-2-create quorum post operator set migration feat: operator set migration-2-create quorum Jul 26, 2024
Copy link
Contributor

@ypatil12 ypatil12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment

src/RegistryCoordinator.sol Show resolved Hide resolved
Copy link
Contributor

@ypatil12 ypatil12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added one minor comment, but approving

@@ -3,6 +3,7 @@ pragma solidity ^0.8.12;

import {IPauserRegistry} from "eigenlayer-contracts/src/contracts/interfaces/IPauserRegistry.sol";
import {ISignatureUtils} from "eigenlayer-contracts/src/contracts/interfaces/ISignatureUtils.sol";
import {AVSDirectory} from "eigenlayer-contracts/src/contracts/core/AVSDirectory.sol";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can we import interface? Does the interface not have all functions we need?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the interface was missing a function initially.

I'll double check if it's there now

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was there now b69d253

Base automatically changed from feat/migration to feat/operate-set-release-branch August 12, 2024 13:46
@stevennevins stevennevins merged commit fe93ac6 into feat/operate-set-release-branch Aug 12, 2024
2 of 3 checks passed
@stevennevins stevennevins deleted the feat/migration-2-create-quorum branch August 12, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants